Skip to content

8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used #2494

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
GoeLin wants to merge 2 commits into from
Closed

8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used #2494

GoeLin wants to merge 2 commits into from

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Nov 28, 2025 •
edited by openjdk bot
Loading

I backport this for parity with 21.0.11-oracle.

Needed to resolve and adapt larger parts of ResumeChecksServer.java as https://bugs.openjdk.org/browse/JDK-8357033 is not in 21.

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8333857 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/2494/head:pull/2494
$ git checkout pull/2494

Update a local copy of the PR:
$ git checkout pull/2494
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/2494/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2494

View PR using the GUI difftool:
$ git pr show -t 2494

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/2494.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Nov 28, 2025

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@GoeLin GoeLin changed the title Goetz backport 8327980 backport e6ebefaa404daa4160bdc1c5d9c954c040e2c0c2 Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025 •
edited
Loading

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used

Reviewed-by: mbaesken

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title backport e6ebefaa404daa4160bdc1c5d9c954c040e2c0c2 8333857: Test sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java failed: Existing session was used Nov 28, 2025
@openjdk
Copy link

openjdk bot commented Nov 28, 2025

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Nov 28, 2025
@mlbridge
Copy link

mlbridge bot commented Nov 28, 2025

Webrevs

MBaesken
MBaesken reviewed Dec 4, 2025
View reviewed changes
test/jdk/sun/security/ssl/SSLSessionImpl/ResumeChecksServer.java
params.setNeedClientAuth(true);
params.setAlgorithmConstraints(new NoSig(
first ? "ecdsa_secp521r1_sha512" :
"ecdsa_secp384r1_sha384"));
Copy link
Member

@MBaesken MBaesken Dec 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems those constraints ecdsa_secp521r1_sha512 / ecdsa_secp384r1_sha384 came in with https://bugs.openjdk.org/browse/JDK-8357033 .
Have you checked if this is okay ?

Copy link
Member Author

@GoeLin GoeLin Dec 9, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, this is a change of JDK-8357033 I included here.
But I think the change is not really related to 8357033, but rather giving the test more recent ciphers. They are both also available in 21.
We could probably use the old code (ecdsa/rsa), but maybe using the new ones is a good improvement? It is unlikely 8357033 is backported.

@MBaesken
Copy link
Member

MBaesken commented Dec 4, 2025

Looks mostly okay; not 100% sure about the SIGNATURE_SCHEME constraints settings, do you want them here?

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received and removed approval Requires approval; will be removed when approval is received labels Dec 5, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label Dec 12, 2025
@GoeLin
Copy link
Member Author

GoeLin commented Dec 12, 2025

/integrate

@openjdk
Copy link

openjdk bot commented Dec 12, 2025

Going to push as commit 2d4c2aa.
Since your change was applied there have been 19 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Dec 12, 2025
@openjdk openjdk bot closed this Dec 12, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Dec 12, 2025
@openjdk
Copy link

openjdk bot commented Dec 12, 2025

@GoeLin Pushed as commit 2d4c2aa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@GoeLin GoeLin deleted the goetz_backport_8327980 branch December 12, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@MBaesken MBaesken MBaesken approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@GoeLin @MBaesken